fix: prepend spaceship root folder to spaceship precompile path #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spaceship-prompt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for contributing! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
## [4.5.1](v4.5.0...v4.5.1) (2022-09-30) ### Bug Fixes * **kubectl:** Avoids checking kubectl server version if no context is loaded, stopping potential hangs ([#1246](#1246)) ([44819b0](44819b0)) * prepend spaceship root folder to spaceship precompile path ([#1244](#1244)) ([6c4623f](6c4623f)) * upsearch was exiting when the first file is not found ([#1239](#1239)) ([dcfd690](dcfd690))
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When spaceship-prompt precompile libs, it's done by providing the full path to
spaceship::precompile,but in the case ofprompt_spaceship_setup/spaceship.zsh, that doesn't happen, which leads to issue #1188This PR prepends the
$SPACESHIP_ROOTvar to the arguments of that line to provide the full path of the file.