Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Coverage #458

Open
5 of 36 tasks
denysdovhan opened this issue May 29, 2018 · 4 comments
Open
5 of 36 tasks

Tests: Coverage #458

denysdovhan opened this issue May 29, 2018 · 4 comments
Assignees
@maximbaz @denysdovhan @salmanulfarzy
Labels
good first issue Issue or PR is friendly to new contributors: easy and simple. help-wanted We need help to resolve this issue or PR. improvement A PR that make small changes for improving UX, performance, readability, etc

Comments

@denysdovhan
Copy link
Member

denysdovhan commented May 29, 2018 •
edited

#457 introduced some tests for lib modules and main sections, like dir, host, user and char. More tests are yet to come.

I hope this issue are gonna help new contributors.

Tests

Here's a list of sections that should be covered with tests:

  • sections
    • aws
    • battery
    • char
    • conda
    • dir
    • docker
    • dotnet
    • elixir
    • elm
    • exec_time
    • exit_code
    • git
      • git_branch
      • git_status
    • golang
    • haskell
    • hg
      • hg_branch
      • hg_status
    • host
    • jobs
    • julia
    • kubecontext
    • line_sep
    • node
    • package
    • php
    • python
    • ruby
    • rust
    • swift
    • time
    • user
    • venv
    • xcode
@denysdovhan denysdovhan added help-wanted We need help to resolve this issue or PR. improvement A PR that make small changes for improving UX, performance, readability, etc good first issue Issue or PR is friendly to new contributors: easy and simple. labels May 29, 2018
@denysdovhan denysdovhan mentioned this issue May 29, 2018
Merged
@rodrigo-garcia-leon
Copy link

Hi, I'd like to work on this one. I'm thinking on picking up the vi_mode tests

@salmanulfarzy
Copy link
Member

That would be great @rodrigo-garcia-leon

@rodrigo-garcia-leon rodrigo-garcia-leon mentioned this issue Oct 21, 2018
Closed
@denysdovhan
Copy link
Member Author

Let's require all of the new sections to have tests before merging them.

@denysdovhan denysdovhan mentioned this issue Nov 26, 2018
Merged
@salmanulfarzy salmanulfarzy pinned this issue Dec 14, 2018
@leonardovillela
Copy link
Contributor

I also think it's a good idea to have tests for install and uninstall script.

@denysdovhan denysdovhan mentioned this issue Sep 2, 2022
Closed
@Runrioter Runrioter unpinned this issue Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximbaz maximbaz

@denysdovhan denysdovhan

@salmanulfarzy salmanulfarzy

Labels
good first issue Issue or PR is friendly to new contributors: easy and simple. help-wanted We need help to resolve this issue or PR. improvement A PR that make small changes for improving UX, performance, readability, etc
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maximbaz @denysdovhan @rodrigo-garcia-leon @leonardovillela @salmanulfarzy