Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix satdet regression test failure in dev and public #28

Closed
pllim opened this issue Jul 11, 2017 · 7 comments
Closed

Fix satdet regression test failure in dev and public #28

pllim opened this issue Jul 11, 2017 · 7 comments
Assignees

Comments

@pllim
Copy link
Collaborator

pllim commented Jul 11, 2017

Satellite detection trail regression test in ACSTOOLS started failing on June 14, 2017. At first, I thought it was due to astropy/astropy#6207 but that was not merged into Astropy dev until June 15. Both code and test data have not been recently changed, so it is likely that some behavior change upstream (scipy?) caused this.

https://ssb.stsci.edu/pandokia/pandokia.cgi?query=detail&key_id=102860998

Note: Affects both test machines on dev.

c/c @dborncamp

GIF courtesy of Dave Borncamp blinking between bad output and good "truth":
satdetfail

@pllim pllim self-assigned this Jul 11, 2017
@pllim pllim changed the title Fix satdet regression test failure Fix satdet regression test failure in dev Jul 11, 2017
@pllim pllim changed the title Fix satdet regression test failure in dev Fix satdet regression test failure in dev and public Jul 11, 2017
@dborncamp
Copy link

I see the test failing in the pandokia engine but can I get at the data somehow?

@dborncamp
Copy link

I cannot reproduce this error. Could you give me more information on the environment?

@pllim
Copy link
Collaborator Author

pllim commented Jul 11, 2017

@jhunkeler or @rendinam know where to dig that out.

@pllim
Copy link
Collaborator Author

pllim commented Jul 11, 2017

@dborncamp , by the way, in the test log given above, don't worry about the traceback at the end, but rather note that fitsdiff reported differences in result, which I think is also what you see?

@pllim
Copy link
Collaborator Author

pllim commented Jul 11, 2017

Update: Dave Borncamp was unable to produce the bad output on his environment but I am able to... My bet is on some changes upstream between Astropy 1.3 and 2.0. Maybe astropy/astropy#5991 but why it did not show up until June 14 on dev (which is supposed to pick up Astropy dev), I don't know.

@pllim
Copy link
Collaborator Author

pllim commented Jul 13, 2017

There are still some differences but they appear to me as aliasing effect: https://ssb.stsci.edu/pandokia/pandokia.cgi?query=detail&key_id=105008197

@dborncamp, those files are temporarily at /eng/ssb/lim/acstools_issue29. Please have a look and see if the differences are acceptable. Thanks!

@pllim pllim reopened this Jul 13, 2017
@dborncamp
Copy link

These changes are good. Thanks @pllim!

@pllim pllim closed this as completed Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants