New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: Lazy tree as default #1728
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
commented
Jan 5, 2024
braingram
commented
Jan 5, 2024
braingram
commented
Jan 5, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream failures when turning
lazy_tree
on by default:type_equality
: https://github.com/BAMWelDX/weldx/blob/ad4b8dc8d976c1306cbdfd409c84e73f288c5686/weldx/util/util.py#L195load_dataset
grabs a reference to part of an open asdf file (after opening it withlazy_load=False
): https://github.com/DKISTDC/dkist/blob/e5cf0f9c598c56cd5bc1514d9149fac03cc9896f/dkist/dataset/loader.py#L159 so this should be updated to includelazy_tree=False
. Similar issues exist for theeit_dataset
andsmall_visp_dataset
fixtures: https://github.com/DKISTDC/dkist/blob/e5cf0f9c598c56cd5bc1514d9149fac03cc9896f/dkist/conftest.py#L260wfss
tests are failing due to handling of the reference file data in assign wcs where the file is closed after references to portions of the file are captured: https://github.com/spacetelescope/jwst/blob/b762c669639416d61b6e7d3facc5cbee2d6bc9b0/jwst/assign_wcs/nircam.py#L365C44-L365C51 Given the limited use of pure asdf files in jwst, stdatamodels could be updated to disable "lazy_tree" when opening an asdf file. A regression test run with a modified stdatamodels shows the usual random errors (msa_fail/nofail) and one seemingly unrelated unclosed file error: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1130/AsdfDictNode
instance is not json serializable (more on this later)Checklist: