chmod html_dir to ensure writability #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asv's HTML output is made by copying a "template" directory, which lives alongside asv's code (e.g. in /usr or the like), to the destination, which is then modified to contain the benchmark data. If the template is read-only, e.g. due to the filesystem it's stored on, then we can copy it across, but don't have permission to modify it (e.g. getting OSError 13 "permission denied" when trying to make the graph/ subdir). This change runs chmod to grant write permission to the owner (the current user) immediately after the copy, so we avoid such "permission denied" errors.
|
Changes Unknown when pulling e22664e on Warbo:master into ** on spacetelescope:master**. |
|
Should use a for loop, not generator expression.
|
|
Changes Unknown when pulling ed33725 on Warbo:master into ** on spacetelescope:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asv's HTML output is made by copying a "template" directory, which lives
alongside asv's code (e.g. in /usr or the like), to the destination, which is
then modified to contain the benchmark data.
If the template is read-only, e.g. due to the filesystem it's stored on, then we
can copy it across, but don't have permission to modify it (e.g. getting OSError
13 "permission denied" when trying to make the graph/ subdir).
This change runs chmod to grant write permission to the owner (the current user)
immediately after the copy, so we avoid such "permission denied" errors.