Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor specviz parser #2487

Open
Jdaviz-Triage-Bot opened this issue Sep 28, 2023 · 0 comments
Open

Refactor specviz parser #2487

Jdaviz-Triage-Bot opened this issue Sep 28, 2023 · 0 comments
Labels

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Sep 28, 2023

Reporter: pllim

In general, the specviz parser is messy. Handling of spectrum list results in a lot of special logic route. I think things like these can be cleaned up:

  • get rid of casting np.array(list of Quantity) because it looks unnecessary and cause the results to lose unit that later have to be manually re-attached, which also is prone to subtle bug if there is a case where inputs have mixed units and also defeats the purpose of passing in Quantity in the first place
  • get rid of double for loop in Python; can probably be vectorized
  • see if handling of spectrum list vs single spectrum can be made more elegant in general to ease future maintenance

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants