Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDAT-1228: Implement Astrowidgets API in Imviz Helper #631

Closed
pllim opened this issue May 20, 2021 · 2 comments
Closed

JDAT-1228: Implement Astrowidgets API in Imviz Helper #631

pllim opened this issue May 20, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@pllim
Copy link
Contributor

pllim commented May 20, 2021

In order to try and enable astrowidgets for Imviz in the future, try and see if we can get Imviz to at least support the astrowidgets API.

https://jira.stsci.edu/browse/JDAT-1228

@pllim pllim added the imviz label May 20, 2021
@pllim pllim added this to the Imviz 1.0 milestone May 20, 2021
@pllim pllim self-assigned this May 20, 2021
@pllim
Copy link
Contributor Author

pllim commented May 20, 2021

Summary from meeting with @eteq on 2021-05-21:

  • We will ducktype existing astrowidgets API without introducing actual astrowidgets dependency. This API list will come from what is in astrowidgets/core.py, not from https://github.com/eteq/nb-astroimage-api (also see Leveraging and synergize implementation with original design astropy/astrowidgets#136).
  • Existing astrowidgets API will be divided into two groups:
    • Must-have: Must be implemented to statisfy MVP.
    • Nice-to-have: Only implement if it is trivial. Otherwise, raise NotImplementedError.
      • This includes parser APIs. Currently in Imviz, load_data delegates to the underlying parsers.py, but there are explicit methods for each data type, e.g., load_fits, load_nddata, etc. @eteq needs to think about how to consolidate these two different designs.
  • @eteq wants marker APIs to be MVP but this is up in the air due to the following:
  • I will open a draft PR outlining the above decisions for further discussions.

@pllim
Copy link
Contributor Author

pllim commented Jul 6, 2021

Broken down into smaller tickets.

@pllim pllim closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant