Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat-field step doesn't handle ref file DQ flags properly #187

Closed
hbushouse opened this issue Aug 25, 2016 · 1 comment
Closed

Flat-field step doesn't handle ref file DQ flags properly #187

hbushouse opened this issue Aug 25, 2016 · 1 comment

Comments

@hbushouse
Copy link
Collaborator

The Build 6 testers in INS have discovered that the DQ flags from a flat-field ref file are not being handled properly within the flat-field step. This is due to the fact that the flat-field ref file - at least in some cases - is being loaded into a MultiSlitModel and this data model does NOT call the routine to perform dynamic DQ flag remapping. So the ref file DQ values are being left as is, instead of being translated via the settings in the DQ_DEF table included in the ref file.

A couple of possible solutions include:

  1. switching the flat-field step back to loading ref files using a FlatModel, now that we don't have NIRSpec flats in the form of MultiSlitModel's anymore. The FlatModel data model does apply the dynamic DQ remapping.

  2. Adding dynamic DQ remapping to all data models (such as MultiSlitModel), at least when a DQ_DEF table is available.

@hbushouse
Copy link
Collaborator Author

Fixed in #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant