Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scipy and numpy nightly wheels to dev dependencies #7423

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jan 5, 2023

This PR adds the scipy and numpy nightly wheels to the dev dependencies, so that we can detect issues like the scipy 1.10.0 release prior to that release.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 78.52% // Head: 78.52% // No change to project coverage 👍

Coverage data is based on head (e88029e) compared to base (6110e91).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7423   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files         455      455           
  Lines       39148    39148           
=======================================
  Hits        30740    30740           
  Misses       8408     8408           
Flag Coverage Δ *Carryforward flag
nightly 78.51% <ø> (ø) Carriedforward from f25d3ee
unit 51.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added automation Continuous Integration (CI) and testing automation tools testing labels Jan 5, 2023
@zacharyburnett
Copy link
Collaborator

It looks like the versions of numpy and scipy are not affected in the environment:
https://github.com/spacetelescope/jwst/actions/runs/3849362407/jobs/6558268913

numpy==1.24.1
...
scipy==1.9.3

@braingram
Copy link
Collaborator

Does the tox.ini file need PIP_EXTRA_INDEX_URL like in asdf:
https://github.com/asdf-format/asdf/blob/f5cc1aa53e663fcae70bbb7127c0433ce6f9644f/tox.ini#L6-L7

setenv =
    devdeps: PIP_EXTRA_INDEX_URL = https://pypi.anaconda.org/scipy-wheels-nightly/simple

@WilliamJamieson
Copy link
Collaborator Author

WilliamJamieson commented Jan 6, 2023

Does the tox.ini file need PIP_EXTRA_INDEX_URL like in asdf: asdf-format/asdf@f5cc1aa/tox.ini#L6-L7

setenv =
    devdeps: PIP_EXTRA_INDEX_URL = https://pypi.anaconda.org/scipy-wheels-nightly/simple

Yes it probably does, I appear to have overlooked that

@WilliamJamieson WilliamJamieson force-pushed the testing/scipy_numpy_dev branch 2 times, most recently from 499672c to cff27bd Compare January 6, 2023 20:17
Comment on lines 69 to 74
- toxenv: test-devdeps-xdist
os: ubuntu-latest
python-version: '3.10'
- toxenv: test-devdeps-xdist
os: macos-latest
python-version: '3.10'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not needed to run devdeps jobs for every pull request in ci.yml. There's a ci_cron.yml workflow here that runs the devdeps jobs every Monday morning that is probably more appropriate for this. And feel free to run it more often if weekly is not enough to catch these issues.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is up to @zacharyburnett, as they added those changes. My original intent was to just test these as part of our weekly regression tests.

@github-actions github-actions bot removed the automation Continuous Integration (CI) and testing automation tools label Jan 18, 2023
@nden
Copy link
Collaborator

nden commented Jun 26, 2023

I think this is superseded by #7581. If still relevant, please reopen and update.

@nden nden closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants