New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scipy and numpy nightly wheels to dev dependencies #7423
Add scipy and numpy nightly wheels to dev dependencies #7423
Conversation
Codecov ReportBase: 78.52% // Head: 78.52% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #7423 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 455 455
Lines 39148 39148
=======================================
Hits 30740 30740
Misses 8408 8408
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It looks like the versions of numpy==1.24.1
...
scipy==1.9.3 |
Does the tox.ini file need PIP_EXTRA_INDEX_URL like in asdf: setenv =
devdeps: PIP_EXTRA_INDEX_URL = https://pypi.anaconda.org/scipy-wheels-nightly/simple |
Yes it probably does, I appear to have overlooked that |
499672c
to
cff27bd
Compare
.github/workflows/ci.yml
Outdated
- toxenv: test-devdeps-xdist | ||
os: ubuntu-latest | ||
python-version: '3.10' | ||
- toxenv: test-devdeps-xdist | ||
os: macos-latest | ||
python-version: '3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not needed to run devdeps jobs for every pull request in ci.yml. There's a ci_cron.yml workflow here that runs the devdeps jobs every Monday morning that is probably more appropriate for this. And feel free to run it more often if weekly is not enough to catch these issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is up to @zacharyburnett, as they added those changes. My original intent was to just test these as part of our weekly regression tests.
56cc3f5
to
e88029e
Compare
I think this is superseded by #7581. If still relevant, please reopen and update. |
This PR adds the scipy and numpy nightly wheels to the dev dependencies, so that we can detect issues like the scipy 1.10.0 release prior to that release.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR