-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add algorithm parameter to ramp_fit spec #8501
Comments
Comment by Howard Bushouse on JIRA: Fixed by #8503 |
Comment by Howard Bushouse on JIRA: David Law the latest jwst requirements file has stcal pinned to "stcal>=1.7.0,<1.8.0", so while it doesn't yet require stcal 1.7.1 as a minimum, it can be installed with the current jwst/master. |
Howard Bushouse At the moment it's quite confusing though; 1.7.0 is used by default, which will happily accept the algorithm='OLS_C' parameter, print out 'Using algorithm = OLS_C', but then not actually use the C algorithm and keep using the python code instead. If we could update to require 1.7.1 minimum it will be easier to point people at this code to test (in addition to bringing the poisson error fixes into latest dev). |
Comment by Howard Bushouse on JIRA: David Law Agreed. Will do. |
Comment by Howard Bushouse on JIRA: David Law stcal min bumped to 1.7.1 in #8505 So it should be good to go now when using jwst/master. |
Issue JP-3632 was created on JIRA by Melanie Clarke:
In order to support alternate algorithms in the ramp_fit step (e.g. JP-3121), the 'algorithm' parameter needs to be exposed to the user. It is currently a hard-coded attribute in the step; it should instead be added to the spec.
The text was updated successfully, but these errors were encountered: