Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better rescaling test #126

Closed
mperrin opened this issue Aug 23, 2018 · 1 comment
Closed

Better rescaling test #126

mperrin opened this issue Aug 23, 2018 · 1 comment

Comments

@mperrin
Copy link
Collaborator

mperrin commented Aug 23, 2018

Issue by mperrin
Tuesday Nov 03, 2015 at 08:46 GMT
Originally opened as mperrin/poppy#126

A revised test for OpticalElement.getPhasor rescaling that avoids the overly-large arrays encountered in #102
Also adds explicit tests for padding and cropping the resized arrays.

mperrin included the following code: https://github.com/mperrin/poppy/pull/126/commits
@mperrin
Copy link
Collaborator Author

mperrin commented Aug 23, 2018

Comment by mperrin
Tuesday Nov 03, 2015 at 09:12 GMT

bah, I have totally failed to get the right commits into this. it's weird trying to set up a PR entirely within one's own repository.

@mperrin mperrin closed this as completed Aug 23, 2018
@mperrin mperrin mentioned this issue Aug 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mperrin