Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel scale uniformity and FITS keyword documentation #205

Closed
mperrin opened this issue Aug 23, 2018 · 3 comments
Closed

Pixel scale uniformity and FITS keyword documentation #205

mperrin opened this issue Aug 23, 2018 · 3 comments

Comments

@mperrin
Copy link
Collaborator

mperrin commented Aug 23, 2018

Issue by douglase
Thursday Feb 23, 2017 at 14:50 GMT
Originally opened as mperrin/poppy#205


addresses #202 by adding a documentation page, increases the number of combinations of keywords checked for in _find_pixelscale_in_headers() and saves a new "pixunit" keyword.


douglase included the following code: https://github.com/mperrin/poppy/pull/205/commits

@mperrin
Copy link
Collaborator Author

mperrin commented Aug 23, 2018

Comment by coveralls
Thursday Feb 23, 2017 at 15:07 GMT


Coverage Status

Coverage increased (+0.02%) to 64.582% when pulling 755da22 on douglase:refreshnotebooks into 2bf698f on mperrin:master.

@mperrin
Copy link
Collaborator Author

mperrin commented Aug 23, 2018

Comment by douglase
Friday Mar 24, 2017 at 23:08 GMT


Is anything additional needed to merge this?

@mperrin
Copy link
Collaborator Author

mperrin commented Aug 23, 2018

Comment by mperrin
Friday Mar 24, 2017 at 23:31 GMT


Mostly just getting my attention again long enough to merge is. Thanks @douglase !

@mperrin mperrin closed this as completed Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant