Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pass -> pass_number in schemas #349

Open
schlafly opened this issue Jan 5, 2024 · 1 comment
Open

Change pass -> pass_number in schemas #349

schlafly opened this issue Jan 5, 2024 · 1 comment

Comments

@schlafly
Copy link
Collaborator

schlafly commented Jan 5, 2024

Let's change pass -> pass_number in the L3 draft schema and observation schema. We decided on the weekly tag up that there was not a Webb precedent that we needed to follow, and "pass" is a reserved python keyword, so it's annoying.

@PaulHuwe
Copy link
Collaborator

PaulHuwe commented Jan 11, 2024

Need to also change the db Table target name from pass to pass_number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants