Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When installing from deb, errors appear when using spellcheck #22

Closed
Botspot opened this issue Feb 17, 2021 · 6 comments
Closed

When installing from deb, errors appear when using spellcheck #22

Botspot opened this issue Feb 17, 2021 · 6 comments
Labels
status:patch-released Patched in current stable release type:bug Something isn't working

Comments

@Botspot
Copy link
Contributor

Botspot commented Feb 17, 2021

To reproduce:

  • Misspell a word.
  • Right click on that word.
  • Select the correct spelling.

See the error:
2021-02-17-103906_1920x1080_scrot
@SpacingBat3 SpacingBat3 added the status:need-info Further information is requested label Feb 17, 2021
@Botspot
Copy link
Contributor Author

Botspot commented Feb 17, 2021

This issue continues to occur after reinstalling the deb.

@SpacingBat3
Copy link
Owner

There's a bug in the code in lines 24 and 35... but I still can't reproduce this issue for some reason...

@SpacingBat3 SpacingBat3 added type:bug Something isn't working and removed status:need-info Further information is requested labels Feb 17, 2021
@Itai-Nelken
Copy link
Contributor

I changed the lines and spellcheck works fine now.

@SpacingBat3
Copy link
Owner

SpacingBat3 commented Feb 17, 2021 •
edited

I changed the lines and spellcheck works fine now.

This will be fixed in the latest commit in the new patch (1.0.2) and the new minior version (1.1.0)...

I need to make a new branch for it through...

@SpacingBat3 SpacingBat3 reopened this Feb 17, 2021
SpacingBat3 added a commit that referenced this issue Feb 18, 2021
@SpacingBat3
Fixed the bug in spellchecker (#22).
03ff94c
SpacingBat3 added a commit that referenced this issue Feb 18, 2021
@SpacingBat3
Fixed the bug in spellchecker (#22).
0681f99
SpacingBat3 added a commit that referenced this issue Feb 18, 2021
@SpacingBat3
Merge from 1.0.x (#27)
0a00e8a 
* Some minior fixes.

- Fixed (#18) and (#19) issues.
  - Added the icons for the MacOS/Windows builds.
- Some syntax changes.
- Copyright year isn't updated automatically based on the current year from now.
- Splitted electron-forge configuration lines to the new JavaScript file.
- Moved the application documentation to the "docs/" folder.
- Improved building on Linux hosts (with additional BASH script).

* Fixed the bug in spellchecker (#22).

* Improved DEB build in the forge config.
@SpacingBat3
Copy link
Owner

Fixed in commit 03ff94c and pull request #27.

@SpacingBat3
Copy link
Owner

Reverted pull request #27 (fast-forwarded) and merged #28

@SpacingBat3 SpacingBat3 added the status:patch-released Patched in current stable release label Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:patch-released Patched in current stable release type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Botspot @SpacingBat3 @Itai-Nelken