Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_shebang fails on non UTF-8 script #8

Closed
cessenat opened this issue Jun 11, 2021 · 2 comments · Fixed by spack/spack#26793
Closed

filter_shebang fails on non UTF-8 script #8

cessenat opened this issue Jun 11, 2021 · 2 comments · Fixed by spack/spack#26793
Assignees
Labels
bug Something isn't working

Comments

@cessenat
Copy link

Some typically European (Continental) scripts are in some variant of ISO-8859 which python knows as latin-1.
filter_shebang demands an UTF-8 input file so it fails for these scripts.
This is the case on package perl-tk with a copyright (©) character in ptked (Nick Ing-Simmons Copyright).
I made a proposal for modification in spack with PR 24263. It also traps some old Asian encoding.
I report this here following Massimiliano advise.

@alalazo
Copy link
Member

alalazo commented Jun 17, 2021

@tgamblin I don't seem to have permissions to assign people, edit descriptions or attach labels in this repository, so for reference a link to the PR from which this issue originated spack/spack#24263

@tgamblin
Copy link
Member

@alalazo try now -- should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants