Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability for spackbot to suggest opening multiple PRs #18

Closed
wants to merge 6 commits into from

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Jul 16, 2021

…for more than one package!

image

This will close #1
This will close #3

I'm also adding a footer with the spack logo, and updating the docs commands to be correctly labeled.

Signed-off-by: vsoch vsoch@users.noreply.github.com

…than one package

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented Jul 16, 2021

Note: adding a few more features to this PR for easier review. Also I'm going to put the packages comment in comments to be consistent (I don't like that it's not there).

This change requires that the app be listening to issue events, and have
read and write access to issues (to comment)

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented Jul 16, 2021

Update: this PR will now also add pinging maintainers on issues with packages they maintain, e.g:

image

@vsoch
Copy link
Member Author

vsoch commented Jul 16, 2021

okay looks like I can't easily work on #4 tonight - we'd need more discussion on that, so this is ready for review!

vsoch and others added 4 commits July 16, 2021 14:29
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented Jul 24, 2021

ug. Why why why.

@vsoch vsoch closed this Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping maintainers on issues Recommend separate PRs for each package
1 participant