Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luafilesystem fails to download (no, not an echo...). #2682

Closed
hartzell opened this issue Dec 26, 2016 · 5 comments
Closed

luafilesystem fails to download (no, not an echo...). #2682

hartzell opened this issue Dec 26, 2016 · 5 comments
Labels

Comments

@hartzell
Copy link
Contributor

No description provided.

@hartzell
Copy link
Contributor Author

I thought I knew what was going on, but typed to quickly...

Closing, will open a new one if needed.

@hartzell hartzell reopened this Dec 26, 2016
@hartzell
Copy link
Contributor Author

Ok, I was on the right track.

Installing fails thusly:

==> Installing lua-luafilesystem
==> lua is already installed in /isilon/Analysis/scratch/hartzelg/spack/spack-20161226/opt/spack/linux-centos7-x86_64/gcc-5.4.0/lua-5.3.2-aepnygsia6c7ch75hk6n2e4newe2p7cy
==> git is already installed in /isilon/Analysis/scratch/hartzelg/spack/spack-20161226/opt/spack/linux-centos7-x86_64/gcc-5.4.0/git-2.11.0-vkjxn34gdh2uwif6mt25i77lsusoe6l7
==> Fetching https://github.com/keplerproject/luafilesystem/archive/v1_6_3.tar.gz
==> Fetching from https://github.com/keplerproject/luafilesystem/archive/v1_6_3.tar.gz failed.

Because there's a typo in the tag for that version of luafilesystem (luafilesystem issue #88).

Instead of v1_6_3 it was tagged v_1_6_3.

Not sure if they changed the tag recently or if recent changes to make luaposix tightened something up or ...

If someone gives me a hint, I can swing at it. I can imagine customizing something in the luafilesystem package or somewhere more general. Suggestions.

@hartzell
Copy link
Contributor Author

Unsightly hack-around was to change the version to v_1_6_3 ....

diff --git a/var/spack/repos/builtin/packages/lua-luafilesystem/package.py b/var/spack/repos/builtin/packages/lua-luafilesystem/package.py
index fbd2e78b..696ed0bd 100644
--- a/var/spack/repos/builtin/packages/lua-luafilesystem/package.py
+++ b/var/spack/repos/builtin/packages/lua-luafilesystem/package.py
@@ -38,7 +38,7 @@ class LuaLuafilesystem(Package):
     homepage = 'http://keplerproject.github.io/luafilesystem'
     url = 'https://github.com/keplerproject/luafilesystem/archive/v_1_6_3.tar.gz'

-    version('1_6_3', 'd0552c7e5a082f5bb2865af63fb9dc95')
+    version('_1_6_3', 'd0552c7e5a082f5bb2865af63fb9dc95')

     depends_on('git@2.9.3:', type='build')
     extends('lua')

@hartzell hartzell changed the title luafilesystem failes to download (no, not an echo...). luafilesystem fails to download (no, not an echo...). Dec 26, 2016
@adamjstewart
Copy link
Member

It looks like lunarmodules/luafilesystem#88 has been resolved now and they added a new release tag, although the checksum has changed. Do you want to just update the checksum?

@hartzell
Copy link
Contributor Author

Updated the checksum, url, and a bit of the install command to make it work. See #2683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants