-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package started failing with unrecognized -Wthread-safety #30799
Comments
From looking at the logs, the only warning flags that I see passed down to g++ are |
It doesn't remove warning flags, only the "treat warnings as errors" flags, specifically I managed to reproduce the problem, but the cause is a bit strange, the # compile CXX with /home/scogland1/Repos/spack/lib/spack/env/gcc/g++
CXX_DEFINES = -DHAVE_CLANG_THREAD_SAFETY
CXX_INCLUDES =
CXX_FLAGS = -Werror -std=c++11 Since we're now stripping
We could incorporate a patch for that, but it really needs to be fixed upstream as well. |
I see, ok. It looks like they use a different way of checking the flag in version 1.23 and greater: So yes, it needs a patch. |
I think in this case patching is the right thing to do -- either with a |
Yeah, 1.23+ is doing it correctly, so a patch seems like the best option. |
Patch added. |
Was fixed by #30810 |
Steps to reproduce
I am posting this as a bug rather than a build error because although the problem appears when building a package, it was caused by a recent commit to spack, not the package itself (I narrowed it down to commit 330832c, authored by @trws )
$ spack install leveldb@1.22
This command will fail, with g++ complaining that it doesn't know
-Wthread-safety
(I reproduced it on 3 platforms with various versions of gcc).The leveldb package wasn't changed. I looked at its cmake file and the weird thing is that it has a mechanism that checks whether this flag is supported (here: https://github.com/google/leveldb/blob/1.22/CMakeLists.txt#L53) so I don't know if spack is interfering with it in some way.
Error message
No response
Information on your system
General information
spack debug report
and reported the version of Spack/Python/PlatformThe text was updated successfully, but these errors were encountered: