Score-P fails to build

[jordialcaraz]

Steps to reproduce the issue

$ spack spec -l scorep@8.4

Input spec
--------------------------------
 -   scorep@8.4

Concretized
--------------------------------
 -   arve3e6  scorep@8.4%gcc@11.4.0~cuda~hip+mpi+papi~pdt~shmem~unwind build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  rbt7tof      ^binutils@2.42%gcc@11.4.0~gas~gprofng+headers~interwork~ld+libiberty~lto~nls~pgo+plugins build_system=autotools compress_debug_sections=zlib libs=shared,static arch=linux-ubuntu22.04-icelake
[+]  g5arkmk          ^diffutils@3.10%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  lpqoz43              ^libiconv@1.17%gcc@11.4.0 build_system=autotools libs=shared,static arch=linux-ubuntu22.04-icelake
[+]  qf3zylu          ^pkgconf@1.9.5%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  z2lieqx          ^zlib-ng@2.1.6%gcc@11.4.0+compat+new_strategies+opt+pic+shared build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  jv4dq3a          ^zstd@1.5.6%gcc@11.4.0+programs build_system=makefile compression=none libs=shared,static arch=linux-ubuntu22.04-icelake
[+]  enxpbe5      ^cubelib@4.8.2%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  z35kgmo      ^cubew@4.8.2%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  5yfgx5j      ^gcc-runtime@11.4.0%gcc@11.4.0 build_system=generic arch=linux-ubuntu22.04-icelake
[+]  s3okqv5      ^gmake@4.4.1%gcc@11.4.0~guile build_system=generic arch=linux-ubuntu22.04-icelake
[+]  gczvzyn      ^opari2@2.0.8%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  hncwqu5      ^openmpi@5.0.3%gcc@11.4.0~atomics~cuda~gpfs~internal-hwloc~internal-libevent~internal-pmix~java~legacylaunchers~lustre~memchecker~openshmem~orterunprefix~romio+rsh~static+vt+wrapper-rpath build_system=autotools fabrics=none romio-filesystem=none schedulers=none arch=linux-ubuntu22.04-icelake
[+]  jf4tknu          ^autoconf@2.72%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  36zd7dh              ^m4@1.4.19%gcc@11.4.0+sigsegv build_system=autotools patches=9dc5fbd,bfdffa7 arch=linux-ubuntu22.04-icelake
[+]  xxdym6f                  ^libsigsegv@2.14%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  uizapfb          ^automake@1.16.5%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  564fbsy          ^hwloc@2.9.1%gcc@11.4.0~cairo~cuda~gl~libudev+libxml2~netloc~nvml~oneapi-level-zero~opencl+pci~rocm build_system=autotools libs=shared,static arch=linux-ubuntu22.04-icelake
[+]  alx55pr              ^libpciaccess@0.17%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  sntcjvi                  ^util-macros@1.19.3%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  5tnrulr              ^libxml2@2.10.3%gcc@11.4.0+pic~python+shared build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  rch7mld                  ^xz@5.4.6%gcc@11.4.0~pic build_system=autotools libs=shared,static arch=linux-ubuntu22.04-icelake
[+]  seq5ad5              ^ncurses@6.4%gcc@11.4.0~symlinks+termlib abi=none build_system=autotools patches=7a351bc arch=linux-ubuntu22.04-icelake
[+]  dfd6cj4          ^libevent@2.1.12%gcc@11.4.0+openssl build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  5cveziu              ^openssl@3.2.1%gcc@11.4.0~docs+shared build_system=generic certs=mozilla arch=linux-ubuntu22.04-icelake
[+]  pd2x76r                  ^ca-certificates-mozilla@2023-05-30%gcc@11.4.0 build_system=generic arch=linux-ubuntu22.04-icelake
[+]  y46fopg          ^libtool@2.4.7%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  zxgkakh              ^findutils@4.9.0%gcc@11.4.0 build_system=autotools patches=440b954 arch=linux-ubuntu22.04-icelake
[+]  svkiqig          ^numactl@2.0.14%gcc@11.4.0 build_system=autotools patches=4e1d78c,62fc8a8,ff37630 arch=linux-ubuntu22.04-icelake
[+]  765sm4h          ^openssh@9.7p1%gcc@11.4.0+gssapi build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  rwpjftx              ^krb5@1.20.1%gcc@11.4.0+shared build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  w644ajr                  ^bison@3.8.2%gcc@11.4.0~color build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  ocb5nls                  ^gettext@0.22.4%gcc@11.4.0+bzip2+curses+git~libunistring+libxml2+pic+shared+tar+xz build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  4uyzomh                      ^tar@1.34%gcc@11.4.0 build_system=autotools zip=pigz arch=linux-ubuntu22.04-icelake
[+]  zcanrox                          ^pigz@2.8%gcc@11.4.0 build_system=makefile arch=linux-ubuntu22.04-icelake
[+]  y3ewkzj              ^libedit@3.1-20230828%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  muvfkcn              ^libxcrypt@4.4.35%gcc@11.4.0~obsolete_api build_system=autotools patches=4885da3 arch=linux-ubuntu22.04-icelake
[+]  h5lf7ha          ^perl@5.38.0%gcc@11.4.0+cpanm+opcode+open+shared+threads build_system=generic patches=714e4d1 arch=linux-ubuntu22.04-icelake
[+]  65lncau              ^berkeley-db@18.1.40%gcc@11.4.0+cxx~docs+stl build_system=autotools patches=26090f4,b231fcc arch=linux-ubuntu22.04-icelake
[+]  otnsmgr              ^bzip2@1.0.8%gcc@11.4.0~debug~pic+shared build_system=generic arch=linux-ubuntu22.04-icelake
[+]  i5jv4rs              ^gdbm@1.23%gcc@11.4.0 build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  4whmrlv                  ^readline@8.2%gcc@11.4.0 build_system=autotools patches=bbf97f1 arch=linux-ubuntu22.04-icelake
[+]  b52tpon          ^pmix@5.0.1%gcc@11.4.0~docs+pmi_backwards_compatibility~python~restful build_system=autotools arch=linux-ubuntu22.04-icelake
[+]  l7cq5aj      ^otf2@3.0.3%gcc@11.4.0 build_system=autotools patches=7e56d93 arch=linux-ubuntu22.04-icelake
[+]  yn6rgo3      ^papi@7.1.0%gcc@11.4.0~cuda~debug+example~infiniband~lmsensors~nvml~powercap~rapl~rocm~rocm_smi~sde+shared~static_tools build_system=autotools patches=48cb202 arch=linux-ubuntu22.04-icelake

Error message

Error: AttributeError: type object 'super' has no attribute 'with_or_without'

The 'scorep' package cannot find an attribute while trying to build from sources. This might be due to a change in Spack's package format to support multiple build-systems for a single package. You can fix this by updating the build recipe, and you can also report the issue as a bug. More information at https://spack.readthedocs.io/en/latest/packaging_guide.html#installation-procedure

/storage/users/jalcaraz/spackkkk/spack/var/spack/repos/builtin/packages/scorep/package.py:157, in with_or_without:
156 def with_or_without(self, arg):

157 return super.with_or_without(arg).remove_suffix("=yes")

Information on your system

• Spack: 0.22.0.dev0 (b362362)
• Python: 3.10.12
• Platform: linux-ubuntu22.04-icelake
• Concretizer: clingo

Additional information

@wrwilliams

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
• I have uploaded the build log and environment files
• I have searched the issues of this repo and believe this is not a duplicate

[wrwilliams]

@jordialcaraz I have just grabbed a fresh checkout and attempted to reproduce this in a matching container, without success:

* **Spack:** 0.22.0.dev0 (b362362291816679873d5f2dad37a31748d7e42c)
* **Python:** 3.10.12
* **Platform:** linux-ubuntu22.04-m1
* **Concretizer:** clingo

spack spec -l scorep@8.4 works fine in the spack/ubuntu-jammy container, as does spack install scorep@8.4. The concretize for me is basically identical modulo system differences:

[+]  fqy2pny  scorep@8.4%gcc@11.4.0~cuda~hip+mpi+papi~pdt~shmem~unwind build_system=autotools arch=linux-ubuntu22.04-m1

Am I missing a critical step in the reproducer here?

[jordialcaraz]

Hi @wrwilliams

I just tried it cloning spack, and spack install scorep@8.4 and I get the same using two different systems (the second is the same as before):
1st

• Spack: 0.22.0.dev0 (eb2ddf6)
• Python: 3.10.12
• Platform: linux-ubuntu22.04-skylake
• Concretizer: clingo
  2nd
• Spack: 0.22.0.dev0 (eb2ddf6)
• Python: 3.10.12
• Platform: linux-ubuntu22.04-icelake
• Concretizer: clingo

[wrwilliams]

...okay, this keeps getting weirder.

I tried to force rebuilding everything from scratch:

spack install -U --overwrite scorep@8.4
==> The following package specs will be reinstalled:

-- linux-ubuntu22.04-m1 / gcc@11.4.0 ----------------------------
fqy2pny scorep@8.4%gcc ~cuda~hip+mpi+papi~pdt~shmem~unwind build_system=autotools
==> Do you want to proceed? [y/N] y
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/gcc-runtime-11.4.0-wzyxn6rob5xfksskwbsrsakuvrmjgpn6
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/otf2-3.0.3-nc2kq5ns3htffutmxxu22qph6lhyrt47
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/gnuconfig-2022-09-17-4ehslpn2hjjepjpcripyevo5wbcirfij
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/bzip2-1.0.8-pmualr3vpvwo5ifra6ihxea5mxd2e6b7
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/gmake-4.4.1-nd2cb7krvbwsft3dadpqbazzp4trqkrc
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/papi-7.1.0-blzterjr5bfqvi6kvsrscm2qz7w6nij6
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/opari2-2.0.8-a6ghfpu5ndatajuolbdjipfd664oej73
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/ncurses-6.4-4nt22j5hpoaveklvh3cjvus3d5up75ko
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/zlib-ng-2.1.6-niu2u4zknkux4n6vv4ckyw2kajkavbgf
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/libpciaccess-0.17-e7cnpcoaxvnud4qamoeis7mgvjaadmho
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/numactl-2.0.14-v5iwpwu3wkq5gusopr5np4lmz5h6nust
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/zstd-1.5.6-52z3eyofbqwd4xnr3taqx2gk5n527s5e
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/libxcrypt-4.4.35-pt675uatn3kfw7y45dfdybmbwojw363z
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/libiconv-1.17-6b623p3py23ohw6aw4qacfoeyv5l27an
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/xz-5.4.6-qhc5egth4a7yfzrloqzwtbfryspyiejf
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/libedit-3.1-20230828-athz3keuwk7ixxlcyqlfqp5gzl2k5qps
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/cubelib-4.8.2-ted7vscwjduqb7pbedcksqircqjxqjcq
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/openssl-3.2.1-eik2blgtbrk524gs5ukuzdfj6jt7xhe7
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/cubew-4.8.2-zqoe75ejjtukm6vtspb3wi6hgama7mhj
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/pigz-2.8-k4wh43vtrc2kw5uvygdz6nnw3rgv6c3i
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/binutils-2.42-vcoptnuk4y7wtkkvn3zwju2whgnzh7wz
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/libxml2-2.10.3-6badnoyd5i5ccrdu5fbsdmxsuqhb4qnt
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/libevent-2.1.12-vvzir5b54aqhd56s4lm2at73g24ymgt3
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/tar-1.34-lk5bmoeis5w42p6qti3kqmkm67ytoegr
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/hwloc-2.9.1-zuplyemjoiwzpairjq3ijp5zcjzxzsme
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/gettext-0.22.4-5euipqoapja323svm3rarpwmobegqwv7
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/pmix-5.0.1-qksh2hbex6glr7dmldu4qesnhpi54nsb
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/krb5-1.20.1-neuqayu54he22ssc7gpxzi6r6psyvlvj
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/openssh-9.7p1-3y2en4iijbqslljp6dld3cb4aqr4ue4n
[+] /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/openmpi-5.0.3-nmqbvcynh5zeeei657rh3mjkq6iolaff
==> Installing scorep-8.4-fqy2pnytbg6gucmxbd6hzhc4r3km4qbm [31/31]
==> No binary for scorep-8.4-fqy2pnytbg6gucmxbd6hzhc4r3km4qbm found: installing from source
==> Error: AttributeError: Query of package 'openmpi' for 'headers' failed
	prefix : /opt/spack/opt/spack/linux-ubuntu22.04-m1/gcc-11.4.0/openmpi-5.0.3-nmqbvcynh5zeeei657rh3mjkq6iolaff
	spec : openmpi@=5.0.3%gcc@=11.4.0~atomics~cuda~gpfs~internal-hwloc~internal-libevent~internal-pmix~java~legacylaunchers~lustre~memchecker~openshmem~orterunprefix~romio+rsh~static+vt+wrapper-rpath build_system=autotools fabrics=none romio-filesystem=none schedulers=none arch=linux-ubuntu22.04-m1 ^[deptypes=build] autoconf@=2.72%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build] automake@=1.16.5%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] berkeley-db@=18.1.40%gcc@=11.4.0+cxx~docs+stl build_system=autotools patches=26090f4,b231fcc arch=linux-ubuntu22.04-m1 ^[deptypes=build] bison@=3.8.2%gcc@=11.4.0~color build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link,run] bzip2@=1.0.8%gcc@=11.4.0~debug~pic+shared build_system=generic arch=linux-ubuntu22.04-m1 ^[deptypes=build] ca-certificates-mozilla@=2023-05-30%gcc@=11.4.0 build_system=generic arch=linux-ubuntu22.04-m1 ^[deptypes=build] diffutils@=3.10%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,run] findutils@=4.9.0%gcc@=11.4.0 build_system=autotools patches=440b954 arch=linux-ubuntu22.04-m1 ^[deptypes=link] gcc-runtime@=11.4.0%gcc@=11.4.0 build_system=generic arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] gdbm@=1.23%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] gettext@=0.22.4%gcc@=11.4.0+bzip2+curses+git~libunistring+libxml2+pic+shared+tar+xz build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build] gmake@=4.4.1%gcc@=11.4.0~guile build_system=generic arch=linux-ubuntu22.04-m1 ^[deptypes=build] gnuconfig@=2022-09-17%gcc@=11.4.0 build_system=generic arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] hwloc@=2.9.1%gcc@=11.4.0~cairo~cuda~gl~libudev+libxml2~netloc~nvml~oneapi-level-zero~opencl+pci~rocm build_system=autotools libs=shared,static arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] krb5@=1.20.1%gcc@=11.4.0+shared build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] libedit@=3.1-20230828%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] libevent@=2.1.12%gcc@=11.4.0+openssl build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link virtuals=iconv] libiconv@=1.17%gcc@=11.4.0 build_system=autotools libs=shared,static arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] libpciaccess@=0.17%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] libsigsegv@=2.14%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build] libtool@=2.4.7%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=link] libxcrypt@=4.4.35%gcc@=11.4.0~obsolete_api build_system=autotools patches=4885da3 arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] libxml2@=2.10.3%gcc@=11.4.0+pic~python+shared build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,run] m4@=1.4.19%gcc@=11.4.0+sigsegv build_system=autotools patches=9dc5fbd,bfdffa7 arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] ncurses@=6.4%gcc@=11.4.0~symlinks+termlib abi=none build_system=autotools patches=7a351bc arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] numactl@=2.0.14%gcc@=11.4.0 build_system=autotools patches=4e1d78c,62fc8a8,ff37630 arch=linux-ubuntu22.04-m1 ^[deptypes=run] openssh@=9.7p1%gcc@=11.4.0+gssapi build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] openssl@=3.2.1%gcc@=11.4.0~docs+shared build_system=generic certs=mozilla arch=linux-ubuntu22.04-m1 ^[deptypes=build,run] perl@=5.38.0%gcc@=11.4.0+cpanm+opcode+open+shared+threads build_system=generic patches=714e4d1 arch=linux-ubuntu22.04-m1 ^[deptypes=run] pigz@=2.8%gcc@=11.4.0 build_system=makefile arch=linux-ubuntu22.04-m1 ^[deptypes=build virtuals=pkgconfig] pkgconf@=1.9.5%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] pmix@=5.0.1%gcc@=11.4.0~docs+pmi_backwards_compatibility~python~restful build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] readline@=8.2%gcc@=11.4.0 build_system=autotools patches=bbf97f1 arch=linux-ubuntu22.04-m1 ^[deptypes=build,link] tar@=1.34%gcc@=11.4.0 build_system=autotools zip=pigz arch=linux-ubuntu22.04-m1 ^[deptypes=build] util-macros@=1.19.3%gcc@=11.4.0 build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link,run] xz@=5.4.6%gcc@=11.4.0~pic build_system=autotools libs=shared,static arch=linux-ubuntu22.04-m1 ^[deptypes=build,link virtuals=zlib-api] zlib-ng@=2.1.6%gcc@=11.4.0+compat+new_strategies+opt+pic+shared build_system=autotools arch=linux-ubuntu22.04-m1 ^[deptypes=build,link,run] zstd@=1.5.6%gcc@=11.4.0+programs build_system=makefile compression=none libs=shared,static arch=linux-ubuntu22.04-m1
	queried as : openmpi
	extra parameters : []

The 'scorep' package cannot find an attribute while trying to build from sources. This might be due to a change in Spack's package format to support multiple build-systems for a single package. You can fix this by updating the build recipe, and you can also report the issue as a bug. More information at https://spack.readthedocs.io/en/latest/packaging_guide.html#installation-procedure

So same sort of error, but triggered by querying openmpi for headers--which we can be pretty sure is a property that exists.

I don't know what's going on but I am doubtful it's actually caused by my recent changes--would be curious what the causal chain is though.

[wspear]

It looks like the issue was introduced here: 1bf92c7 (The parent of that commit, eefe0b2, builds just fine). I can't figure out how that commit ever worked for anyone. Where does 'remove_suffix' even come from? It's not an attribute of string, or anything else in python that I can find.

[wrwilliams]

It looks like the issue was introduced here: 1bf92c7 (The parent of that commit, eefe0b2, builds just fine). I can't figure out how that commit ever worked for anyone. Where does 'remove_suffix' even come from? It's not an attribute of string, or anything else in python that I can find.

Should of course be rstrip. Am on mobile now but will post a MR in the morning.