WTH - Additional details #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 25, 2016 14:13
Added link to Service form for adding an additional details survey. Pivotal Tracker ID - [#118787429]
I added a Questionnaire model, along with an Item model that belongs to the parent Questionnaire object. Enabled adding nested fields on the fly through the use of the Gem 'nested_fields_for'. Modified migrations to incorporate additional features that were included in Iowa's original interpretation.
I refactored into form partial
I successfully tested redirect to index action after successful form submission. Added controller tests to test creation of Questionnaire and Item objects.
added 5 commits
August 18, 2016 15:49
… surveys if the user has not already taken them
|
First glance, this looks awesome!!!! |
| @@ -144,6 +146,10 @@ def self.cents_to_dollars cents | |||
| cents.to_i / 100.0 | |||
| end | |||
|
|
|||
| def has_additional_details | |||
|
Only suggestions are:
|
|
@kyle-glick Thanks for the suggestions. These are really helpful. The reason I did partials is because they will render based on an Item's type. So if item.item_type == 'checkbox' for example, the form will render the partial "checkbox_form_partial" Seemed like the best way to do it programatically as we are dealing with several different types of questions (checkboxes, radios, multiselects') |
| = javascript_include_tag 'jquery.qtip.min.js' | ||
| = csrf_meta_tags | ||
|
|
||
| %body{ style: 'background: none;' } |
There was a problem hiding this comment.
Maybe this inline style should go into a stylesheet.
|
Killer PR! |
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new Additional Details module where Service Providers can create service specific surveys in order to gain feedback from users in SPARC-Request.
Users can create surveys through Catalog Manager where a user can click 'Add Additional Details', which redirects you to manage the surveys for specific Services.
There, a user can utilize the form builder tool to create surveys that accept multiple different types of questions. Also, a user can preview how a form would look like before they actually create a new Questionnaire record.
Once a Questionnaire is created, a user can then manage its 'active' state. Only 'active' questionnaires will be available to take in SPARC-Request. The link to take them will appear on the Document Management page when submitting a new Service Request.
A user does not have to complete the Questionnaire at that time, as they can also take them via links in their user dashboard.
Pivotal Tracker Story Ids
Additional Details Part 1 - #118787429
Additional Details Part 2 - #118787985