@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Hey @VishnuSanal 👋

Thanks for the PR, but I see no changes in the PR. Could you have a look again?

Hey @VishnuSanal 👋

Thanks for the PR, but I see no changes in the PR. Could you have a look again?

ouch!! that lost somewhere whilst fixing the CI. :D PTAL now :)

Hey @VishnuSanal

I have made some changes and have added a few suggestions. Do let me know what you think 😄

Also, @VishnuSanal , please add an integration test. Add a route in integration_tests/base_routes.py and then make a curl request on both the routes like this - https://github.com/sparckles/Robyn/blob/main/integration_tests/test_get_requests.py

please add an integration test. Add a route in integration_tests/base_routes.py and then make a curl request on both the routes like this - https://github.com/sparckles/Robyn/blob/main/integration_tests/test_get_requests.py

@sansyrox why add a new route? also, why integration_tests/test_get_requests.py? wouldn't modifying integration_tests/test_basic_routes.py like this suffice? 🤔

@VishnuSanal , we tend to add one route for its function. If you explore the file, you will find out that we have one dedicated route for get requests, one for posts, etc.

why add a new route? also, why integration_tests/test_get_requests.py? wouldn't modifying integration_tests/test_basic_routes.py like

The latest updates on your projects. Learn more about Vercel for Git ↗︎

CodSpeed Performance Report

Merging #819 will not alter performance

_{Comparing VishnuSanal:main (a773240) with main (00ca522)}

Summary

✅ 108 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

@VishnuSanal , the ci is failing on formatting. Can you please fix that?

All looks good to merge otherwise 😄

Great work @VishnuSanal 😄