Moves WiFi tester from system-part2 into user module

[avtolstoy]

Problem

We are currently running low on flash space in system-part2. As WiFiTester code is mainly used during manufacturing and testing, we can move it out of system firmware into a user module and enable it conditionally.

Solution

Moves WiFiTester into the user module 😄

Sizes comparisons:
0.7.0-rc.3:

   text	   data	    bss	    dec	    hex	filename
 261108	    156	    268	 261532	  3fd9c	../../../build/target/system-part1/platform-6-m/system-part1.elf
   text	   data	    bss	    dec	    hex	filename
 252972	   2260	  38484	 293716	  47b54	../../../build/target/system-part2/platform-6-m/system-part2.elf
   text	   data	    bss	    dec	    hex	filename
   6468	    156	   1400	   8024	   1f58	../../../build/target/user-part/platform-6-m/tinker.elf

This branch

   text	   data	    bss	    dec	    hex	filename
 261108	    156	    268	 261532	  3fd9c	../../../build/target/system-part1/platform-6-m/system-part1.elf
   text	   data	    bss	    dec	    hex	filename
 249788	   2260	  38508	 290556	  46efc	../../../build/target/system-part2/platform-6-m/system-part2.elf
   text	   data	    bss	    dec	    hex	filename
  10900	    156	   1400	  12456	   30a8	../../../build/target/user-part/platform-6-m/tinker.elf

Steps to Test

• tinker
• app/listen_mode test
• wifitester app

Example App

#include "application.h"

// Enables WiFiTester 
STARTUP(System.enable(SYSTEM_FLAG_WIFITESTER_OVER_SERIAL1));
STARTUP(System.enableFeature(FEATURE_WIFITESTER));

void setup() {
}

void loop() {
}

References

• CH7262

---

Completeness

• User is totes amazing for contributing!
• Contributor has signed CLA (Info here)
• Problem and Solution clearly stated
• Run unit/integration/application tests on device
• Added documentation
• Added to CHANGELOG.md after merging (add links to docs and issues)

[m-mcgowan]

Doesn't look to me like this macro is used? Is it possible to replace the SETUP_WIFITESTER_IMPL() macro with a regular function? It would be simpler to read and maintain as a function.

[m-mcgowan]

ping @avtolstoy - any thoughts on that?

[avtolstoy]

SETUP_WIFITESTER() is not used and instead we now enable it via STARTUP(System.enableFeature(FEATURE_WIFITESTER));, so it can be removed.

I'll try moving the implementation into a function today.