Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spark-react test errors/warnings for proptypes in NDS to get us to 100% successful test #2238

Closed
afebbraro opened this issue Oct 28, 2019 · 0 comments
Closed

Fix spark-react test errors/warnings for proptypes in NDS to get us to 100% successful test #2238

afebbraro opened this issue Oct 28, 2019 · 0 comments
Assignees
@afebbraro
Labels
js: react For issues related to React packages status: PO approved Approved by PO - Ready for Engineer to pick up
Milestone
10.21.19-11.1.19

Comments

@afebbraro
Copy link
Contributor

afebbraro commented Oct 28, 2019 •
edited by ssabo1

User Story:
We have been getting react test errors/warnings since the new docs site started. See below screenshot. We need this fixed so that our tests can be 100% successful again and so that we don't get errors/warnings when running the tests
Screen Shot 2019-10-28 at 8 27 55 AM

This involves our react package SprkLinks (element), SprkCardTeaser (ctaLinkElement, mediaLinkElement) and SprkMasthead (logoLinkElement).
@afebbraro afebbraro mentioned this issue Oct 28, 2019
Merged
12 tasks
@ssabo1 ssabo1 added js: react For issues related to React packages status: PO approved Approved by PO - Ready for Engineer to pick up labels Oct 28, 2019
@ssabo1 ssabo1 added this to the 10.21.19-11.1.19 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afebbraro afebbraro

Labels
js: react For issues related to React packages status: PO approved Approved by PO - Ready for Engineer to pick up
Projects
None yet
Milestone
10.21.19-11.1.19
Development

No branches or pull requests
2 participants
@afebbraro @ssabo1