Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing Archetypes #74

Closed
proofconstruction opened this issue Sep 8, 2021 · 11 comments
Closed

Reproducing Archetypes #74

proofconstruction opened this issue Sep 8, 2021 · 11 comments

Comments

@proofconstruction
Copy link
Collaborator

I spent an uncomfortable amount of time staring at the selected archetypes (in the Google Drive folder everyone reading this should have access to), and wrote some notes about each of them.

These notes are at the top of Colab notebooks in that same Google Drive folder, where we can work on the associated images.

@proofconstruction
Copy link
Collaborator Author

I've added a small block to gdown and display the image, so we have it available for reference while building these pipelines.

All of the archetypes now have separate issues, linked above. We should discuss reproduction of each specific archetype in its own issue, and any discussion of the general project should occur in this issue.

@proofconstruction
Copy link
Collaborator Author

Most of the original documents have some very sparse noise in the form of small black spots, only a few across the whole page. In my notes for each of these I said we might use BadPhotoCopy with a very low noise_density to achieve this effect, but I don't think this will work.

Which augmentation should we use to randomly introduce just a few small dots?

@kwcckw
Copy link
Collaborator

kwcckw commented Sep 11, 2021

Most of the original documents have some very sparse noise in the form of small black spots, only a few across the whole page. In my notes for each of these I said we might use BadPhotoCopy with a very low noise_density to achieve this effect, but I don't think this will work.

Which augmentation should we use to randomly introduce just a few small dots?

At this point, I think it would be still BadPhotoCopy, I'm still exploring on those additional hash types to generate different kind of noise effect, I will compile a list of possible effect with BadPhotoCopy later.

@kwcckw
Copy link
Collaborator

kwcckw commented Sep 12, 2021

Most of the original documents have some very sparse noise in the form of small black spots, only a few across the whole page. In my notes for each of these I said we might use BadPhotoCopy with a very low noise_density to achieve this effect, but I don't think this will work.

Which augmentation should we use to randomly introduce just a few small dots?

I created some variant of noises, and to clarify, is any of example below match the one you mentioned?

Example1:
image

Example2:
image

Example3:
image

Or is it something similar to lighter version of salt and pepper noise?

@proofconstruction
Copy link
Collaborator Author

These are close, but we need even less noise. This will be good for a few of the documents, but most of them only have a few (less than maybe 10) dots

@kwcckw
Copy link
Collaborator

kwcckw commented Sep 14, 2021

These are close, but we need even less noise. This will be good for a few of the documents, but most of them only have a few (less than maybe 10) dots

I updated the hash types and it should be hash type 4 to reproduce this effect, so i guess that's the best I can do now and please check again here: #88

@proofconstruction
Copy link
Collaborator Author

Everyone should be able to edit the Colab notebooks linked in the other issues.

We need to focus on trying to reproduce these documents, so we can either have a good result to show or we can identify new augmentations/changes to existing ones if we run into problems.

@kwcckw
Copy link
Collaborator

kwcckw commented Sep 17, 2021

@proofconstruction I just tested with 1 - Letter - Diahann Carroll - 1972.ipynb, so there are some issues when we combine several augmentations, there are some bugs and causing the unexpected output, I will check again and let you know again.

Also right now badphotography is setting input as ink layer, it should be relevant in ink layer right?

@proofconstruction
Copy link
Collaborator Author

there are some issues when we combine several augmentations, there are some bugs and causing the unexpected output,

What are the issues and bugs?

Also right now badphotography is setting input as ink layer, it should be relevant in ink layer right?

I think we should try to allow augmentations in any layer unless they really need to be in just one for technical reasons, so we should add layer="post" and self.layer = layer to the constructor, then change to image = data[self.layer][-1].result in the __call__ method.

@kwcckw
Copy link
Collaborator

kwcckw commented Sep 18, 2021

there are some issues when we combine several augmentations, there are some bugs and causing the unexpected output,

What are the issues and bugs?

Sorry, from my further investigation, actually it's just due to different parameter values, now it looks fine, you may check on the output again: https://colab.research.google.com/drive/1lK85t83WAXb0dwLyZtcROzc7D-qLu9MY?usp=sharing

I think it's looking good now:
image

Also right now badphotography is setting input as ink layer, it should be relevant in ink layer right?

I think we should try to allow augmentations in any layer unless they really need to be in just one for technical reasons, so we should add layer="post" and self.layer = layer to the constructor, then change to image = data[self.layer][-1].result in the __call__ method.

Okay, then i will add this in later for some other relevant augmentations too.

@proofconstruction
Copy link
Collaborator Author

Closed with PR #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants