Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #69 fix breaks samd/variants/SparkFun_RedBoard_Turbo/variant.cpp #72

Closed
DavidArmstrong opened this issue Nov 11, 2020 · 1 comment

Comments

@DavidArmstrong
Copy link

Lines 199-203 in samd/variants/SparkFun_RedBoard_Turbo/variant.cpp now reads as follows:

// 44 - RGB LED
{ PORTA, 30, PIO_DIGITAL, (PIN_ATTR_DIGITAL), No_ADC_Channel, NOT_ON_PWM, NOT_ON_TIMER, EXTERNAL_INT_NONE } // 44: RGB LED

//45
{ PORTB, 3, PIO_SERCOM_ALT, PIN_ATTR_NONE, No_ADC_Channel, NOT_ON_PWM, NOT_ON_TIMER, EXTERNAL_INT_NONE }, // 31/RX: SERCOM5/PAD[3]

The pin definition for Pin 44 needs to end in a comma, after the closing right brace, so that the new Pin 45 definition that follows it is valid. As it is now, compiling a sketch on the Redboard Turbo generates a compiler error here.

@edspark
Copy link
Contributor

edspark commented Nov 12, 2020

You are right, I've fixed it and verified the fix. Sorry about the completely unnecessary headache.

@edspark edspark closed this as completed Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants