Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10 Eng. Checklist Issues #5

Closed
ericorosel opened this issue Aug 22, 2017 · 1 comment
Closed

v10 Eng. Checklist Issues #5

ericorosel opened this issue Aug 22, 2017 · 1 comment

Comments

@ericorosel
Copy link

(1) 32u4 package used is not currently in the Sparkfun-Libraries (don't forget prod-ID)

(2) RGB LED package used is not currently in the Sparkfun-Libraries

NOTE: I see that the packages live in the "newlilypadparts" lbr in the hardware folder, but I'm not sure when the parts actually get added to the official SFE libraries. If the parts normally get merged to the outward facing Eagle libraries after this point than ignore (1) and (2).

(3) the Buzzer GND signal in the schematic does not use a GND symbol

(4) BOM and design discrepancies:

  • Sparkle page needs product name changed to match new name
  • 32u4 needs prod-ID
  • one 10K needs to be subtracted from the Sparkle BOM
  • one 1K needs to be added to the Sparkle BOM

(5) Should the bottom left of the board be on (0, 0) to avoid issues with non-pay Eagle use? (i guess not really a thing anymore)

(6) Is it worth getting rid of some of the orphans in the design? It just looks kind of funny in parts (non necessary fix)

(7) the D2 trace has an unnecessary right angle. I missed this on v01

(8) Do the traces on the Buzzer need to be at an angle not divisible by 45? (non necessary fix)

(9) I don't think we will ever need fiducials on the bottom of this design, but because it's on the design checklist if figured I would include it. (non necessary fix)

@marshalltaylorSFE
Copy link
Contributor

1, 2 fixed
3 leaving alone (sewtabs priority over gnd symbol for this sub board)
4, 5 fixed
6 left, lilypad design opinion favors orphans
7 fixed! I missed that too
8 as by lilypad design
9 agreed, this was my note in the check too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants