Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong mask #12

Closed
embs-be opened this issue Apr 7, 2015 · 3 comments
Closed

Wrong mask #12

embs-be opened this issue Apr 7, 2015 · 3 comments

Comments

@embs-be
Copy link

embs-be commented Apr 7, 2015

https://github.com/sparkfun/MMA8452_Accelerometer/blob/master/Firmware/libraries/SFE_MMA8452Q/SFE_MMA8452Q.cpp#L116

should be ctrl &= 0xC7;

ODR takes 3 bytes :)
@embs-be embs-be changed the title Wronf mask Wrong mask Jun 3, 2015
@hermanbanken
Copy link

Think that this is fixed. Right? Looking at Libraries/Arduino/src/SparkFun_MMA8452Q.cpp#L118 that is...

Just reporting this because of the Boy Scout rule 👍 I was browsing this library for a new project. Looks great!

@embs-be
Copy link
Author

embs-be commented Nov 11, 2015

Nope. Old code still there.

@jimblom
Copy link

jimblom commented Jan 21, 2016

Pulled in the latest version of the Arduino Library. Should be fixed now.

@jimblom jimblom closed this as completed Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimblom @hermanbanken @embs-be