Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve signing key compatibility with other cryptography libraries #2470

Closed
zorgiepoo opened this issue Nov 18, 2023 · 1 comment · Fixed by #2472
Closed

Improve signing key compatibility with other cryptography libraries #2470

zorgiepoo opened this issue Nov 18, 2023 · 1 comment · Fixed by #2472

Comments

@zorgiepoo
Copy link
Member

zorgiepoo commented Nov 18, 2023

As discussed in #2467, our private signing key using https://github.com/orlp/ed25519 is not compatible with other libraries. This is because other libraries use seed or seed + public_key as their private key and instead oral/ed25519 hashes the seed so it doesn't have to re-hash it on every signing operation. Presently we discard the seed before the hashing operation so it is impossible to sign updates using other libraries which may be beneficial on other OS systems / toolchains / etc.

Proposal is that for newly generated keys, we preserve the seed. Potentially the new format could be seed + public_key and we would just derive the private key from the seed and public_key again. On export/import we may want to consider using a binary format instead of base64 but I'm not sure yet. Compatibility considerations may need to be made so older tools don't accidentally leak newly generated private keys.

@zorgiepoo
Copy link
Member Author

We don't need to store the public_key. Changes to resolve this are in #2472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant