Fix issue #458: Basic authentication fails when specifying credentials for a realm that contains uppercase characters #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per RFC 1945 (section 11) and RFC 2617, the realm value is case sensitive. This commit adds tests for realm case sensitivity in Mechanize::HTTP::AuthStore.
As per RFC 1945 (section 11) and RFC 2617, the realm value is case sensitive. This commit adds tests for realm case sensitivity in Mechanize::HTTP::AuthRealm.
As per RFC 1945 (section 11) and RFC 2617, the realm value is case sensitive. This commit adds tests for realm case sensitivity in Mechanize::HTTP::AuthChallenge.
As per RFC 1945 (section 11) and RFC 2617, the realm value is case sensitive. This commit adds tests for realm case sensitivity in Mechanize::HTTP::WWWAuthenticateParser.
As per RFC 1945 (section 11) and RFC 2617, the realm name is case sensitive. This commit stops Mechanize::HTTP::AuthRealm#initialize downcasing the passed realm name. Resolves sparklemotion#458.
knu
added a commit
that referenced
this pull request
Feb 19, 2016
Fix issue #458: Basic authentication fails when specifying credentials for a realm that contains uppercase characters
|
Looks good, I'll add an entry to CHANGELOG.rdoc shortly. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #458: Basic authentication fails when specifying credentials for a realm that contains uppercase characters.
This PR adds various tests for case sensitivity in realm name and fixes the issue itself.
All tests pass with this fix.