Only prepend http:// if it wasn't provided #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbrain
reviewed
Dec 8, 2017
lib/mechanize/http/agent.rb
Outdated
| @@ -1234,7 +1234,7 @@ def set_proxy addr, port, user = nil, pass = nil | |||
| end | |||
| end | |||
|
|
|||
| proxy_uri = URI "http://#{addr}" | |||
| proxy_uri = URI (addr =~ %r(^https?://) ? addr : "http://#{addr}") | |||
There was a problem hiding this comment.
I've updated the commit to split the string manipulation from the URI parsing. Please let me know if there's anything else, as I'm relatively fresh to this.
ttilberg
force-pushed
the
512-set_proxy-prepends-value-with-http-regardless-of-what-is-passed-in
branch
from
ac2911d
to
983f53c
Compare
knu
added a commit
that referenced
this pull request
Jun 2, 2018
ttilberg
deleted the
512-set_proxy-prepends-value-with-http-regardless-of-what-is-passed-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible solution for issue #512 where Mechanize is forcing
http://into the string, even if it was provided.I don't know how far back in ruby versions things like
=~and%r(regex)go, so if these need to be changed to get better backwards compat, I'm all ears!