Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply arrow format env var for spark < 3 #2538

Closed
nealrichardson opened this issue May 26, 2020 · 1 comment
Closed

Only apply arrow format env var for spark < 3 #2538

nealrichardson opened this issue May 26, 2020 · 1 comment
Assignees
Labels

Comments

@nealrichardson
Copy link
Contributor

For compatibility with older versions of Arrow used by Spark, we set this environment variable when writing arrow data: https://github.com/sparklyr/sparklyr/blob/master/R/core_arrow.R#L3-L4

Spark 3.0 will include a bump of the Arrow version it uses (in Java) from 0.12.0 to 0.15.1 (apache/spark#26133). So with that Arrow version, we won't need this legacy format flag. (It shouldn't crash if we use the flag, but there was a reason for the format change in Arrow, and we should avoid legacy codepaths if we can.)

What this means is that we should move where that env var is set (temporarily or otherwise) to the appropriate place that know what Spark version it's communicating with. As it stands currently in core_arrow.R, the spark context isn't known.

@nealrichardson
Copy link
Contributor Author

This was done in #2544 so it can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants