Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are the Structure sites pre-sorted when they're downloaded from Materials Project? #77

Open
sgbaird opened this issue Jun 10, 2022 · 2 comments
Open

Are the Structure sites pre-sorted when they're downloaded from Materials Project? #77

sgbaird opened this issue Jun 10, 2022 · 2 comments

Comments

@sgbaird
Copy link
Member

sgbaird commented Jun 10, 2022

May want to verify this and add as a unit test
@sgbaird sgbaird mentioned this issue Jun 10, 2022
Open
@sgbaird sgbaird transferred this issue from sparks-baird/mp-time-split Jun 17, 2023
@kjappelbaum
Copy link

May want to verify this and add as a unit test

put perhaps I would not rely on that and simply always call get_sorted_structure first?

@sgbaird
Copy link
Member Author

sgbaird commented Jul 1, 2023 •
edited
Loading

@kjappelbaum that's a good point! I'll try to look for a good place to put this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjappelbaum @sgbaird