Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add Electrum compatible BIP39 restore option #238

Closed
igorglv opened this issue Oct 5, 2021 · 13 comments
Closed

Feature request: add Electrum compatible BIP39 restore option #238

igorglv opened this issue Oct 5, 2021 · 13 comments

Comments

@igorglv
Copy link

igorglv commented Oct 5, 2021

Right now if one wants to restore a wallet from an Electrum mnemonic words, Sparrow shows "Invalid checksum" error. If one imports Electrum wallet directly, Sparrow correctly shows seeds as "Electrum Seed Version System".

Request 1: to add a "Electrum 12 words" menu item in "Mnemonic Words (BIP39)" and may be remove "enter ...", so the menu will looks like "Electrum 12 words" "BIP39 12 words" "BIP39 15 words" "BIP39 18 words" ...

Request 2: add a conversion option from Electrum seeds to BIP39 words in "View Seed..."

@craigraw
Copy link
Collaborator

craigraw commented Oct 5, 2021

For the reasons discussed in #59, I don't want to add Request 1 in Sparrow. Having two seed standards introduces more confusion, and it would do the community a disservice to support creating ESVS seeds. The current support is intended as a restore option for Electrum wallets, but ultimately I believe it is wise to migrate such wallets to a more widely compatible standard.

I don't believe Request 2 is possible, unfortunately.

@craigraw craigraw closed this as completed Oct 5, 2021
@igorglv
Copy link
Author

igorglv commented Oct 5, 2021

I understand the reasoning but it creates absolutely terrible user experience. I knew that the words are correct, so I entered it multiple times, restarted Sparrow and tried again, though that this functionality is currently broken, googled and got nothing, nothing is the help files...
How about to add a warning message for the "12 words" option that Sparrow does not support Electrum seeds (and maybe other well known non standard wallets) and one must import the wallet directly?

@craigraw
Copy link
Collaborator

craigraw commented Oct 6, 2021

Agreed, this is exactly why two seed standards almost identical in appearance make for bad UX.

I've implemented your suggestion in b9d6cb1.

Screenshot 2021-10-06 at 08 19 57

@dazza9x
Copy link

dazza9x commented Mar 8, 2023

Sparrow is not able to import the electrum file? Any ideas?

@dazza9x
Copy link

dazza9x commented Mar 8, 2023

image

@craigraw
Copy link
Collaborator

craigraw commented Mar 8, 2023

The message in the screenshot contains all the information you need already. Create a new wallet with your BIP39 seed words.

@gus4rs
Copy link

gus4rs commented Mar 28, 2023

What about the labels? Is there a way to import them from an Electrum BIP39 wallet at least? Electrum allows to export labels in the following format:

{
    "txid1": "label1",
    "txid2": "label2",
}

@craigraw
Copy link
Collaborator

Labels from Electrum wallets will be imported with the File > Import Wallet > Electrum feature.

@gus4rs
Copy link

gus4rs commented Mar 28, 2023

Can't see this option in 1.7.3, but I can see "wallet labels", so I need to convert the Electrum export in the BIP format?

@craigraw
Copy link
Collaborator

It's 6th on the list.

@gus4rs
Copy link

gus4rs commented Mar 28, 2023

The 6h on the list is "Coldcard multisig" the 7th is "Electrum" but this is to import the full wallet and doesn't work with wallets that are not electrum seed native

@craigraw
Copy link
Collaborator

True, that's an Electrum limitation. Your best option is to convert the Electrum labels export to the BIP format.

@gus4rs
Copy link

gus4rs commented Mar 28, 2023

Yep, I converted it and it worked, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants