Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: include keystore labels in animated QR exports #911

Closed
seedhammer opened this issue Mar 21, 2023 · 5 comments
Closed

Feature request: include keystore labels in animated QR exports #911

seedhammer opened this issue Mar 21, 2023 · 5 comments

Comments

@seedhammer
Copy link

The BCR-2020-007 format for crypto-hdkey includes an optional name value:

	? name: text,                        ; A short name for this key.

We'd like to include keystore labels in our steel engravings, for which it would be nice if Sparrow exported them. I suppose the same information could be included in PDF backups, so labels are restored from backups.

@craigraw
Copy link
Collaborator

As of 4bec71e, Sparrow will now read the name value from scanned ur:crypto-hdkeys and set the keystore label if present. Sparrow does not currently show xpubs as ur:crypto-hdkey QRs however due to the need for wide compatibility.

Using this field for keystore labels in ur:crypto-output is a good idea too, so keeping this open for now.

@seedhammer
Copy link
Author

Thank you. Indeed I wasn't clear: the feature request is about amending the ur:crypto-output QRs, not individual xpub QRs (which we don't use).

@seedhammer seedhammer changed the title Feture request: include keystore labels in animated QR exports Feature request: include keystore labels in animated QR exports Jun 22, 2023
@seedhammer
Copy link
Author

seedhammer commented Aug 24, 2023

Gentle ping. We'd love to start engraving titles on our plates, but no wallet supports ur:crypto-output titles yet. If you still think it's a good idea, having this feature in Sparrow would allow us to implement support on our end and nudge other wallets :)

@satscoffee
Copy link

Would love to this feature so we could generate titles upon export!

@craigraw
Copy link
Collaborator

Implemented in 76dc294. Sparrow will now export keystore labels in displayed ur:crypto-output QRs (including PDF exports), and import keystore labels if present in the ur:crypto-hdkey components of scanned ur:crypto-output QRs. Note that Sparrow restricts keystore labels to 16 characters, and ensures that they are unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants