New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows/port.cc:TmpFile returns a pointer to a local varaible #43

Closed

GoogleCodeExporter opened this issue Aug 14, 2015 · 1 comment

Labels

auto-migrated Priority-Medium Type-Defect

GoogleCodeExporter commented Aug 14, 2015

We found this bug with a static analysis tool.  It's an easy fix.  Line 55
of src/windows/port.cc has: 

char tmppath_buffer[1024];

line 62 has:

return tmppath_buffer;

oops.  

What version of the product are you using? On what operating system?

I found this in version 1.3, but it's still there in 1.5.2.

Original issue reported on code.google.com by jrl...@gmail.com on 7 Oct 2009 at 9:15

The text was updated successfully, but these errors were encountered:

GoogleCodeExporter added Priority-Medium Type-Defect auto-migrated labels

Author

GoogleCodeExporter commented Aug 14, 2015

This is actually fine -- the function returns a string, not a pointer, so the 
local
buffer is converted to a string before being returned.

I'm closing this as NotABug.  Though maybe it's a good bug to file with the 
static
analysis tool? :-)

Original comment by csilv...@gmail.com on 12 Oct 2009 at 12:18

Changed state: WontFix
Added labels: Priority-Medium, Type-Defect

GoogleCodeExporter closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment