Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX-UI: Resolve outstanding Percentage Swap Button issue #182

Closed
SP-Nate opened this issue Oct 22, 2020 · 1 comment
Closed

UX-UI: Resolve outstanding Percentage Swap Button issue #182

SP-Nate opened this issue Oct 22, 2020 · 1 comment
Labels

Comments

@SP-Nate
Copy link
Contributor

SP-Nate commented Oct 22, 2020

On the Swap page, the buttons for 25%, 50%, 75% and All are not functioning as efficiently as possible, with several issues:

By default, the 'Total' is populated with a rounded amount of an asset, which will trigger a contract error (attempting to swap more token than exists in the wallet).

  • Recommend enhancing this to automatically calculate the max value to 'N' decimal places, however round DOWN the display to two decimal places. This will allow users to swap 'all' of a token and not have any leftover dust, but will visually be easier to read.

Inserting a manual Total will render the buttons obsolete, as they are not linked to the prior 'Total' SPARTA in the wallet. Recommend adding a 'Clear existing Total' step to the percentage buttons, to allow it to better adjust the amount presented to an end user.

@SP-Nate SP-Nate changed the title UX-UI: Resolve outstanding Percentage Swap Button UX-UI: Resolve outstanding Percentage Swap Button issue Oct 22, 2020
@SamusElderg
Copy link
Collaborator

closed with #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants