Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Moved to Rename #46

Closed
SpartanJ opened this issue Jul 28, 2013 · 2 comments
Closed

Renaming Moved to Rename #46

SpartanJ opened this issue Jul 28, 2013 · 2 comments

Comments

@SpartanJ
Copy link
Owner

Original report by Ugo Robain (Bitbucket: wizzhard, GitHub: wizzhard).


Hello,

After some tests it seems that Moved event only occurs when a file is renamed. When a file is actually moved we get a couple of event Delete, Add.

May be the Moved event could be renamed Renamed.

@SpartanJ
Copy link
Owner Author

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


The problem is that i can't make this totally consistent, because depends on the backend that the library is using, this is true for some backends but not for all. Sometimes the Move event is reported correctly ( i can't remember which backend reports this fine ), so if i change the event name for Rename it will be wrong, that's why it's called Moved. Take a look at the "Platform limitations and clarifications" in the README file.
Thanks anyways.

@SpartanJ
Copy link
Owner Author

Original comment by Ugo Robain (Bitbucket: wizzhard, GitHub: wizzhard).


Ok i should have read the documentation more carefully.

May be a little Matrix showing which action produce which event(s) would be nice to add to the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant