Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken build on a some toolchains #62

Closed
SpartanJ opened this issue Jun 24, 2014 · 2 comments
Closed

Broken build on a some toolchains #62

SpartanJ opened this issue Jun 24, 2014 · 2 comments
Labels
bug Something isn't working minor

Comments

@SpartanJ
Copy link
Owner

Original report by Anonymous.

I got this error
../../src/efsw/platform/posix/SystemImpl.cpp:91: error: 'PATH_MAX' was not declared in this scope

As i understand in some reason <linux/limits.h> which have PATH_MAX don't imported on a some toolchains but present in its.

To resolve i simply replaced POSIX define PATH_MAX to C++ define FILENAME_MAX.
Patch attached.
@SpartanJ
Copy link
Owner Author

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

Resolved issue #21.
Resolved issue #22.

@SpartanJ
Copy link
Owner Author

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

Ok, it doesn't seem to cause any problems. Change accepted.

Thanks,
Regards

@SpartanJ SpartanJ added minor bug Something isn't working labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SpartanJ