Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jpg texture saving option #11

Closed
SpartanJ opened this issue Jun 10, 2016 · 3 comments
Closed

Add jpg texture saving option #11

SpartanJ opened this issue Jun 10, 2016 · 3 comments
Labels
enhancement New feature or request major

Comments

@SpartanJ
Copy link
Owner

Original report by Malte Haase (Bitbucket: a_teammate, ).


I'd love to give a pr for this but my hq capabilities are limited (and tbh im not really motivated in learning it)

so i mirrored the project to github (its really really easy: "import code" .. url_from_bitbucket and done)
and made a commit there: a-teammate/SOIL2-fork@b48a330

You really have some neat libs, id love to see them somewhere they get attention ( i know im repeating myself here ^^)

(they have issue migration to github too)

@SpartanJ
Copy link
Owner Author

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Thanks!

I thought about adding this many times but i'm not sure if makes sense to add another library to do the job. Also i'm not sure if tiny_jpeg is the best option, it looks a little bit basic ( only 3 compression quality options, minimal implementation ). In other projects I've used jpeg-compressor that works amazingly well, but it's in C++, and i'd prefer to keep the library only with C99 code. Let me think about it a little bit. I'm going to test tiny_jpeg, to see if it's good enough and i'll let you know.

Regards!

@SpartanJ
Copy link
Owner Author

SpartanJ commented Aug 8, 2016

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


I ended up using jo_jpeg adapted to compile as C code. I tested tiny_jpeg side by side with jo_jpeg it gave me much worst results, so decided to use jo_jpeg that it's also smaller in code size.

Regards!

@SpartanJ SpartanJ closed this as completed Aug 8, 2016
@SpartanJ
Copy link
Owner Author

SpartanJ commented Aug 8, 2016

Original comment by Malte Haase (Bitbucket: a_teammate, ).


Very neat, thank you!

@SpartanJ SpartanJ added major enhancement New feature or request labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major
Projects
None yet
Development

No branches or pull requests

1 participant