Test there are column names for table (i.e. table exists) before attempting to use them #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I've been working on some of the same items in a branch (dev-refactor). That is a bigger effort to rip apart the endpoints files into a more testable codebase. Also working on tests in that branch. |
apollolm
added a commit
that referenced
this pull request
Dec 29, 2014
Test there are column names for table (i.e. table exists) before attempting to use them
|
I merged your changes into dev branch as well, which is where I do any changes before they make it into master. There were some conflicts as I also attempted to guard against this problem, but they're merged in there now (4021475). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've simply added guard conditions around the code that uses the column names to prevent the process from crashing when a request is made for a table that does not exist. Should also return an appropriate error response - 404 maybe?