Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fragments #7

Closed
JanTvrdik opened this issue Jul 21, 2020 · 3 comments · Fixed by #8
Closed

Support fragments #7

JanTvrdik opened this issue Jul 21, 2020 · 3 comments · Fixed by #8
Labels
enhancement A feature or improvement

Comments

@JanTvrdik
Copy link

Using GraphQL fragment in query currently results in error

Found unsupported definition in /src/myQuery.graphql

query MyQuery {
	listDocument {
		...documentFields
	}
}

fragment documentFields on Document {
	id
	title
}
@spawnia
Copy link
Owner

spawnia commented Jul 21, 2020

First of all, let me say that I am joyous that someone actually tried using this library 🎉

Do you have a stacktrace, where does the error come from?

@spawnia spawnia added the enhancement A feature or improvement label Jul 21, 2020
@JanTvrdik
Copy link
Author

The error comes from Spawnia\Sailor\Codegen\Generator::ensureOperationsAreNamed.

In Generator.php line 158:

  [GraphQL\Error\Error]
  Found unsupported definition in /src/gql/linkableByUrlQuery.graphql


Exception trace:
  at /src/vendor/spawnia/sailor/src/Codegen/Generator.php:158
 Spawnia\Sailor\Codegen\Generator::ensureOperationsAreNamed() at /src/vendor/spawnia/sailor/src/Codegen/Generator.php:186
 Spawnia\Sailor\Codegen\Generator->parsedDocuments() at /src/vendor/spawnia/sailor/src/Codegen/Generator.php:43
 Spawnia\Sailor\Codegen\Generator->generate() at /src/vendor/spawnia/sailor/src/Console/CodegenCommand.php:41
 Spawnia\Sailor\Console\CodegenCommand->execute() at /src/vendor/symfony/console/Command/Command.php:258
 Symfony\Component\Console\Command\Command->run() at /src/vendor/symfony/console/Application.php:911
 Symfony\Component\Console\Application->doRunCommand() at /src/vendor/symfony/console/Application.php:264
 Symfony\Component\Console\Application->doRun() at /src/vendor/symfony/console/Application.php:140
 Symfony\Component\Console\Application->run() at /src/vendor/spawnia/sailor/sailor:24

If I comment out the call to ensureOperationsAreNamed() I get a different error

In OperationSet.php line 52:

  [Exception]
  The selection stack was unexpectedly empty.


Exception trace:
  at /src/vendor/spawnia/sailor/src/Codegen/OperationSet.php:52
 Spawnia\Sailor\Codegen\OperationSet->peekSelection() at /src/vendor/spawnia/sailor/src/Codegen/ClassGenerator.php:212
 Spawnia\Sailor\Codegen\ClassGenerator->Spawnia\Sailor\Codegen\{closure}() at /src/vendor/webonyx/graphql-php/src/Language/Visitor.php:470
 GraphQL\Language\Visitor::GraphQL\Language\{closure}() at /src/vendor/webonyx/graphql-php/src/Language/Visitor.php:277
 GraphQL\Language\Visitor::visit() at /src/vendor/spawnia/sailor/src/Codegen/ClassGenerator.php:269
 Spawnia\Sailor\Codegen\ClassGenerator->generate() at /src/vendor/spawnia/sailor/src/Codegen/Generator.php:54
 Spawnia\Sailor\Codegen\Generator->generate() at /src/vendor/spawnia/sailor/src/Console/CodegenCommand.php:41
 Spawnia\Sailor\Console\CodegenCommand->execute() at /src/vendor/symfony/console/Command/Command.php:258
 Symfony\Component\Console\Command\Command->run() at /src/vendor/symfony/console/Application.php:911
 Symfony\Component\Console\Application->doRunCommand() at /src/vendor/symfony/console/Application.php:264
 Symfony\Component\Console\Application->doRun() at /src/vendor/symfony/console/Application.php:140
 Symfony\Component\Console\Application->run() at /src/vendor/spawnia/sailor/sailor:24

@spawnia spawnia mentioned this issue Jul 21, 2020
3 tasks
Repository owner deleted a comment from maintux May 14, 2021
@spawnia spawnia changed the title Support GraphQL fragment Support GraphQL fragments Nov 22, 2021
@spawnia spawnia changed the title Support GraphQL fragments Support fragments Nov 22, 2021
@spawnia
Copy link
Owner

spawnia commented Apr 13, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants