Add DistributedMemlet node and scheduling function #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 69.70% 70.87% +1.17%
==========================================
Files 65 70 +5
Lines 7232 7621 +389
==========================================
+ Hits 5041 5401 +360
- Misses 2191 2220 +29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
tbennun
requested changes
Aug 19, 2022
| commworld = MPI.COMM_WORLD | ||
| rank = commworld.Get_rank() | ||
| size = commworld.Get_size() | ||
| if size < utils.prod(sizes): |
There was a problem hiding this comment.
did you know that the pytest dist plugin supports giving a number of ranks as a marker?
There was a problem hiding this comment.
Yes, but here I'd rather fail than skip. Also depends on the schedule sizes.
| for is_input, result in zip([True, False], results): | ||
|
|
||
| # gather internal memlets by the out array they write to | ||
| internal_memlets: Dict[ |
There was a problem hiding this comment.
Maybe look in scope_subgraph
There was a problem hiding this comment.
What do you mean? In case there is a global write in the subgraph? Is that allowed?
Created using spr 1.3.5-beta.1
Created using spr 1.3.5-beta.1
orausch
added a commit
that referenced
this pull request
Aug 28, 2022
This change adds the DistributedMemlet library node and the scheduling function for distributed computation. This allows you to distribute the work in the top-level map of the SDFG by specifying block sizes. The lowering function will analyze the SDFG and try to find MPI nodes that implement the required communication. Pull Request: #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the DistributedMemlet library node and the scheduling
function for distributed computation.
This allows you to distribute the work in the top-level map of the SDFG
by specifying block sizes. The lowering function will analyze the SDFG
and try to find MPI nodes that implement the required communication.