Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build architecture for x86 other than native #711

Closed
kreuzerkrieg opened this issue Mar 11, 2019 · 2 comments
Closed

Allow build architecture for x86 other than native #711

kreuzerkrieg opened this issue Mar 11, 2019 · 2 comments
Assignees
Labels
enhancement Low Low Priority Bug

Comments

@kreuzerkrieg
Copy link
Contributor

At this moment the -march flag is set in the make file (spdk.common.mk file) as -march=native and there is no way to override it. It may be problematic, since the build machine and staging/production may be of different architecture, though it is still x86. For example, build machine may support AVX512 and will generate the assembly accordingly. It will result in SIGILL on machine that has no support for AVX512.

@darsto darsto added this to New in Bug scrub via automation Mar 12, 2019
@darsto
Copy link
Contributor

darsto commented Mar 12, 2019

Bug scrub: We could add a configure option to select the target architecture and pass the same option to underlying libs.

@darsto darsto moved this from New to 12.03 in Bug scrub Mar 12, 2019
@darsto darsto added the Low Low Priority Bug label Mar 26, 2019
@darsto darsto assigned benlwalker and unassigned jimharris Mar 26, 2019
@benlwalker
Copy link
Member

Fixed by 7dbdf87. There are more patches in the works to enable full cross compilation to any target, but that is sufficient to target a specific x86 platform instead of native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Low Low Priority Bug
Projects
None yet
Development

No branches or pull requests

4 participants