New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol error on push promise #237
Comments
@Tresdin may I ask you to provide |
@indutny No problem. |
@Tresdin thank you! May I ask you to also run |
@indutny Here you are. |
Thank you! Two more question to you:
Thank you again! |
@Tresdin you will need to run it like this |
@indutny My output log https://gist.github.com/tresdin/908a0ebf0ea67a9c9783 |
@indutny Sorry for the wrong log. Here is the one with this error. https://gist.github.com/tresdin/e557984ceba774853e3e |
Thank you very much for detailed logs. However, I'm afraid I still need a bit more information than this. May I ask you to open Thank you again! |
Nevermind, I know what is happening. Will create a fix today. |
Ah, actually I was wrong. I still need that |
@indutny I've sent the log to fedor@indutny.com. |
@Tresdin thank you! So the answer for our problem is:
I think if you will handle The idea behind this error message is that you actually push streams on every incoming request, and this error happens if you push the same url twice on the same TLS connection. Thank you very much for providing the log. |
This error still stands when requests are filtered.
How can url be pushed twice on the same TLS connection with my sample code? And also, what is your solution for this error? |
@Tresdin the browser may cancel any PUSH stream if it thinks that it needs to do so (be it duplicate streams, or whatever). The solution is to handle |
@indutny I just want to know the cause of the duplication. You've confirmed that this error is not from node spdy side. So which part of my code causes this error? Or is this a Chrome bug? |
@Tresdin this is not a bug at all. Browser just decides that it does not want to receive any data from that PUSH stream and cancels it. This is completely legal in HTTP2 |
@indutny I think it should be considered as a bug. Browsers assume that this behaviour is incorrect on server side when some duplicated streams are sent. So the problem can only be solved when browsers stop rejecting incoming pushed streams. |
@Tresdin I don't get why it is a bug. Please remove |
I got the protocol error while I was trying to push multiple files via
PUSH_PROMISE
. Here is the sample code.Result:
Anything wrong with my code? Or is this a
node-spdy
bug?The text was updated successfully, but these errors were encountered: