Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPE-2889] Raw request and response access #475

Closed
simplesagar opened this issue Feb 14, 2024 · 0 comments
Closed

[SPE-2889] Raw request and response access #475

simplesagar opened this issue Feb 14, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation High priority Created by Linear-GitHub Sync linear typescriptv2 Created by Linear-GitHub Sync
Milestone

Comments

@simplesagar
Copy link
Member

simplesagar commented Feb 14, 2024

  1. The response envelope that’s returned from SDK methods today will have a new rawRequest: Request field added to it and rawData: unknown which is contains the raw server response.
  2. Our SDKError type that we generate in all SDKs will have the same fields added to it as well
  3. We catch all Zod errors and re-throw them as a custom error that also has raw request, server data and response data when these are available

The first two are backwards compatible changes. The third one isn’t but we believe the blast radius is negligible and the change is a net positive for all customers.

SPE-2889

@simplesagar simplesagar changed the title Raw request and response access [SPE-2889] Raw request and response access Feb 14, 2024
@simplesagar simplesagar added linear typescript Created by Linear-GitHub Sync typescriptv2 Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync and removed typescript Created by Linear-GitHub Sync typescriptv2 Created by Linear-GitHub Sync labels Feb 14, 2024
@simplesagar simplesagar added this to the v.86 milestone Feb 16, 2024
@speakeasy-api speakeasy-api deleted a comment from linear bot Feb 23, 2024
@simplesagar simplesagar modified the milestones: v.86, v.90, v.91 Mar 13, 2024
@simplesagar simplesagar added the documentation Improvements or additions to documentation label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation High priority Created by Linear-GitHub Sync linear typescriptv2 Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants