Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment indicates side effect in method where none exists #114

Open
zellidev0 opened this issue Oct 7, 2022 · 0 comments
Open

Comment indicates side effect in method where none exists #114

zellidev0 opened this issue Oct 7, 2022 · 0 comments

Comments

@zellidev0
Copy link

In the option.dart file a comment suggests that the code below the comment has side effects.

// PURISTS BEWARE: side effecty stuff below -- proceed with caution!

One Method there is the toNullable() method.

It looks like that:

A? toNullable() => fold(() => null, id);

This method does not seem to create a side effect and therefore it should be above the stated comment to avoid confusion.

I would create a PR that moves the method upwords, so that it is above the comment. Would this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant