-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve nodes on code includes #2479
Comments
Yeah, I should fix this. Right now I just generate a brand-new element holding the attributes I parsed from the contents, but merging into the existing element is definitely doable. |
Okay, doing this was a larger project than I thought, but it was worthwhile! Should all be good, but lmk if you have any issues. |
Worked well for my use case. Thanks! While I have your attention, could you merge #2093? I rebase and updated a number of times to sync with latest changes :) |
Reopening because this is temporarily reverted while I bake the code more. See #1773 (comment) for details. |
Hello. Any chance to revisit this? |
Yup, the "temporary" revert is lasting longer than planned, but it should be finished this quarter. |
Specifically, I wrap my code snippets with a Custom Element which presents them as tabs. It would look like this in code
The element
s2q-snippet
renders a two tabs and distributes the snippets in two slots,shape
andquery
Problem is, that the
[slot]
attributes are not preserved in the output if bikeshed.I would expect any additional HTML attributes to be preserved as-is in the rendered HTML
The text was updated successfully, but these errors were encountered: