Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New HTML parser doesn't give sufficient information to solve issues #2498

Closed
annevk opened this issue Mar 22, 2023 · 3 comments
Closed

New HTML parser doesn't give sufficient information to solve issues #2498

annevk opened this issue Mar 22, 2023 · 3 comments

Comments

@annevk
Copy link
Collaborator

annevk commented Mar 22, 2023

All I get is

FATAL ERROR: Spurious / in <a>.

for whatwg/fetch.

See whatwg/fetch#1619 and whatwg/fetch#1621 for sample PRs.

@tabatkins
Copy link
Collaborator

So this is indeed a correct error - you accidentally wrote for/ instead of for=/ in two tags, on line 870 and line 1139.

What's confusing me is that you're not getting the line and column where the error is occurring, as I'm getting it locally:

╰╴bikeshed -f spec
LINE 870:48: Spurious / in <a>.
LINE 1139:27: Spurious / in <a>.

@tabatkins
Copy link
Collaborator

Okay it looks like the issue is that I only output line numbers in one of the possible error output formats, and because y'all use the API it doesn't use the standard console one. Will fix, thanks for catching it.

(Dang tho, this implies y'all have never been getting line-number information even when it was sporadically available before, that sucks.)

@annevk
Copy link
Collaborator Author

annevk commented Mar 22, 2023

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants