Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Suggest an edit" link is sometimes wrong. #2784

Closed
svgeesus opened this issue Feb 2, 2024 · 1 comment
Closed

"Suggest an edit" link is sometimes wrong. #2784

svgeesus opened this issue Feb 2, 2024 · 1 comment

Comments

@svgeesus
Copy link
Contributor

svgeesus commented Feb 2, 2024

The recently published CSS Viewport spec was just corrected after publication because the "Suggest an edit" link was 404:

 <dd><a href="https://github.com/w3c/csswg-drafts/blob/main/css-viewport-1/Overview.bs">GitHub Editor</a>

changed to

    <dd><a href="https://github.com/w3c/csswg-drafts/blob/main/css-viewport/Overview.bs">GitHub Editor</a>

I wasn't sure what to fix in the .bs source so that it gets generated correctly. Is it because the directory name does not have a level?

@tabatkins
Copy link
Collaborator

That line comes from the boilerplate: https://github.com/speced/bikeshed-boilerplate/blob/main/boilerplate/csswg/defaults.include#L6

It uses the [VSHORTNAME] macro, because that's the pattern we use for our folder names. Looks like the css-viewport folder is, indeed, named incorrectly, and should have -1 appended to it.

If I make the change right now it'll make the published spec wrong again, so I'll leave it to you to coordinate the changes. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants