Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxon.isAccepted should be set to true if the taxon is preferred. #1054

Closed
Tracked by #2924
benanhalt opened this issue Nov 8, 2021 · 8 comments
Closed
Tracked by #2924

Taxon.isAccepted should be set to true if the taxon is preferred. #1054

benanhalt opened this issue Nov 8, 2021 · 8 comments
Assignees
Labels
1 - Bug Incorrect behavior of the product
Projects

Comments

@benanhalt
Copy link
Contributor

To Reproduce
Here is one symptom that can be reproduced:

  1. Upload a collection object data set with determinations and taxon mapped (don't map Taxon.isPreferred).
  2. Open the uploaded records in Specify 6.
  3. Any record that is determined to a newly uploaded taxon will show a blank preferred taxon.
  4. The preferred taxon does appear in Specify 7.
    See screenshots below.

Screenshots
image
image

Desktop (please complete the following information):

  • Specify 7 Version 7.6.1

Reported By
Andy

@benanhalt benanhalt added 1 - Bug Incorrect behavior of the product pri:unknown labels Nov 8, 2021
@benanhalt
Copy link
Contributor Author

To fix this, I will add a business rule that automatically sets isAccepted according to whether acceptedId is null.

@benanhalt benanhalt added this to Unsorted in Workbench via automation Nov 8, 2021
@benanhalt benanhalt moved this from Unsorted to In progress in Workbench Nov 8, 2021
@benanhalt benanhalt self-assigned this Nov 8, 2021
@benanhalt
Copy link
Contributor Author

This applies to other trees as well.

@maxpatiiuk
Copy link
Member

Should I hide isAccepted for other trees too?

@benanhalt
Copy link
Contributor Author

Probably. But I'm still investigating why these fields even exist. Let me finish that and I'll let you know.

@maxpatiiuk
Copy link
Member

If it helps, isAccepted is a field many taxon and geography authorities have to mark names as being widely accepted by authorities.

I usually exclude all non accepted taxa from the tree when doing imports

@grantfitzsimmons
Copy link
Contributor

May be fixed in xml-editor

@melton-jason melton-jason added the todo:verify Needs Verification label Jan 21, 2024
@melton-jason
Copy link
Contributor

@specify/ux-testing

This was made into a businessrule as of #2965.
(See #3157 (comment) for more context).

Can the fix be verified and this issue closed?

@melton-jason melton-jason removed the todo:verify Needs Verification label Feb 20, 2024
@melton-jason
Copy link
Contributor

Specify 7 is now correctly setting the isAccepted depending on whether the Taxon is synonymized (True if the Taxon is not synonymzied and False otherwise).

Workbench automation moved this from In progress to Shipped Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
Status: Done
Workbench
  
Shipped
Development

No branches or pull requests

4 participants